[http-client] Fix BeanParam on Eclipse#436
Merged
rbygrave merged 3 commits intoavaje:masterfrom May 21, 2024
Merged
Conversation
low priority, but I guess eclipse prints out the entire method signature
rbygrave
reviewed
May 21, 2024
Contributor
There was a problem hiding this comment.
This does not add anything to the test coverage?
We have @BeanParams in tests/test-client-generation in JunkApi and CommonParams and if we needed more coverage we would add it there?
I'll remove this I think.
Collaborator
Author
There was a problem hiding this comment.
Perhaps so, but these generator tests are what allow me to properly debug the processor with my IDE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess eclipse prints out the entire method signature when doing
ExecutableElement#toString()